presubmit_canned_checks.py - Issue 1034523003: Fine tune const NSClass* presubmit check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 1034523003: Fine tune const NSClass* presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Split regex line Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 27cbc429542baed291000c7754d3bbd3041d6406..49ed07c6f853592116aba2a1366cc4b3ec6c61ee 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -948,7 +948,8 @@ def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):

def _CheckConstNSObject(input_api, output_api, source_file_filter):

"""Checks to make sure no objective-c files have |const NSSomeClass*|."""

pattern = input_api.re.compile(

- r'const\s+NS(?!(Point|Range|Rect|Size)\s*\*)\w*\s*\*')

+ r'(?<!reinterpret_cast<)'

+ r'const\s+NS(?!(Point|Range|Rect|Size)\s*\*)\w*\s*\*')

def objective_c_filter(f):

return (source_file_filter(f) and

« no previous file with comments | « no previous file | no next file » | no next file with comments »