Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: src/pdf/SkPDFFont.cpp

Issue 103423003: Fix refcounting bug for Type1 font usage with more than 255 characters. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFFont.cpp
diff --git a/src/pdf/SkPDFFont.cpp b/src/pdf/SkPDFFont.cpp
index b824506b189715b5ab0f04255716597c95482ae0..f4a543985de9aa7c3f6402b3283a4daf82a57bd3 100644
--- a/src/pdf/SkPDFFont.cpp
+++ b/src/pdf/SkPDFFont.cpp
@@ -878,6 +878,7 @@ SkPDFFont::SkPDFFont(SkAdvancedTypefaceMetrics* info, SkTypeface* typeface,
fFontInfo(info),
bungeman-skia 2013/12/05 18:36:20 fFontInfo(SkSafeRef(info)), fDescriptor(SkSafeRef(
vandebo (ex-Chrome) 2013/12/05 19:34:56 Done. Indeed, I didn't realize that SkSafeRef ret
fDescriptor(relatedFontDescriptor) {
SkSafeRef(info);
+ SkSafeRef(relatedFontDescriptor);
if (info == NULL) {
fFontType = SkAdvancedTypefaceMetrics::kNotEmbeddable_Font;
} else if (info->fMultiMaster) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698