Fix refcounting bug for Type1 font usage with more than 255 characters.

src/pdf/SkPDFFont.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <ctype.h>
 
 #include "SkData.h"
@@ skipping 857 matching lines @@
     *index = CanonicalFonts().find(search);
     return false;
 }
 
 SkPDFFont::SkPDFFont(SkAdvancedTypefaceMetrics* info, SkTypeface* typeface,
                      SkPDFDict* relatedFontDescriptor)
         : SkPDFDict("Font"),
           fTypeface(ref_or_default(typeface)),
           fFirstGlyphID(1),
           fLastGlyphID(info ? info->fLastGlyphID : 0),
           fFontInfo(info),

[bungeman-skia, 2013/12/05 18:36:20]

fFontInfo(SkSafeRef(info)),
fDescriptor(SkSafeRef(relatedFontDescriptor))

here makes this a bit shorter and makes it clear in one place that these two are
ref owning.

[vandebo (ex-Chrome), 2013/12/05 19:34:56]

Done.  Indeed, I didn't realize that SkSafeRef returned the obj.

           fDescriptor(relatedFontDescriptor) {
     SkSafeRef(info);
+    SkSafeRef(relatedFontDescriptor);
     if (info == NULL) {
         fFontType = SkAdvancedTypefaceMetrics::kNotEmbeddable_Font;
     } else if (info->fMultiMaster) {
         fFontType = SkAdvancedTypefaceMetrics::kOther_Font;
     } else {
         fFontType = info->fType;
     }
 }
 
 // static
@@ skipping 531 matching lines @@
 
     insert("FontBBox", makeFontBBox(bbox, 1000))->unref();
     insertInt("FirstChar", firstGlyphID());
     insertInt("LastChar", lastGlyphID());
     insert("Widths", widthArray.get());
     insertName("CIDToGIDMap", "Identity");
 
     populateToUnicodeTable(NULL);
     return true;
 }