Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 103423003: Fix refcounting bug for Type1 font usage with more than 255 characters. (Closed)

Created:
7 years ago by vandebo (ex-Chrome)
Modified:
7 years ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix refcounting bug for Type1 font usage with more than 255 characters. Committed: http://code.google.com/p/skia/source/detail?r=12520

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/pdf/SkPDFFont.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
7 years ago (2013-12-05 18:27:48 UTC) #1
bungeman-skia
https://codereview.chromium.org/103423003/diff/1/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): https://codereview.chromium.org/103423003/diff/1/src/pdf/SkPDFFont.cpp#newcode878 src/pdf/SkPDFFont.cpp:878: fFontInfo(info), fFontInfo(SkSafeRef(info)), fDescriptor(SkSafeRef(relatedFontDescriptor)) here makes this a bit shorter ...
7 years ago (2013-12-05 18:36:20 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/103423003/diff/1/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): https://codereview.chromium.org/103423003/diff/1/src/pdf/SkPDFFont.cpp#newcode878 src/pdf/SkPDFFont.cpp:878: fFontInfo(info), On 2013/12/05 18:36:20, bungeman1 wrote: > fFontInfo(SkSafeRef(info)), > ...
7 years ago (2013-12-05 19:34:56 UTC) #3
bungeman-skia
lgtm
7 years ago (2013-12-05 20:18:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/103423003/20001
7 years ago (2013-12-05 20:53:00 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-05 21:14:04 UTC) #6
Message was sent while issue was closed.
Change committed as 12520

Powered by Google App Engine
This is Rietveld 408576698