Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1034173002: Always update raw pointers when handling interrupts inside RegExp code. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always update raw pointers when handling interrupts inside RegExp code. R=mstarzinger@chromium.org BUG=chromium:469480 LOG=N Committed: https://crrev.com/c67cb287a901ddf03d4ae4dafcf431d09fd3e22c Cr-Commit-Position: refs/heads/master@{#27615}

Patch Set 1 #

Total comments: 1

Patch Set 2 : ports and addressed comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -765 lines) Patch
M src/arm/regexp-macro-assembler-arm.cc View 1 1 chunk +13 lines, -93 lines 0 comments Download
M src/arm64/regexp-macro-assembler-arm64.cc View 1 1 chunk +11 lines, -96 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +13 lines, -93 lines 0 comments Download
M src/isolate.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 1 chunk +13 lines, -92 lines 0 comments Download
M src/mips64/regexp-macro-assembler-mips64.cc View 1 2 1 chunk +14 lines, -93 lines 0 comments Download
M src/ppc/regexp-macro-assembler-ppc.cc View 1 1 chunk +13 lines, -93 lines 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/regexp-macro-assembler.cc View 1 2 1 chunk +71 lines, -19 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 2 1 chunk +13 lines, -93 lines 0 comments Download
M src/x87/regexp-macro-assembler-x87.cc View 1 1 chunk +13 lines, -93 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-469480.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Yang
5 years, 9 months ago (2015-03-26 15:13:45 UTC) #1
Yang
On 2015/03/26 15:13:45, Yang wrote: This is only the ia32 port of this patch. I'd ...
5 years, 9 months ago (2015-03-26 15:14:13 UTC) #2
Michael Starzinger
Approach LGTM. https://codereview.chromium.org/1034173002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/1034173002/diff/1/src/isolate.cc#newcode836 src/isolate.cc:836: if (FLAG_verify_heap && FLAG_stress_compaction) { Needs to ...
5 years, 9 months ago (2015-03-26 15:26:04 UTC) #3
Yang
Added ports and addressed comment. The test fails on MIPS64, but that's due to an ...
5 years, 9 months ago (2015-03-27 12:37:12 UTC) #5
Yang
On 2015/03/27 12:37:12, Yang wrote: > Added ports and addressed comment. > > The test ...
5 years, 8 months ago (2015-03-30 13:11:48 UTC) #6
Michael Starzinger
Still LGTM.
5 years, 8 months ago (2015-03-30 14:18:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034173002/20001
5 years, 8 months ago (2015-03-30 15:11:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/3409)
5 years, 8 months ago (2015-03-30 15:21:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034173002/40001
5 years, 8 months ago (2015-04-07 09:16:02 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-07 09:44:56 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 09:45:12 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c67cb287a901ddf03d4ae4dafcf431d09fd3e22c
Cr-Commit-Position: refs/heads/master@{#27615}

Powered by Google App Engine
This is Rietveld 408576698