components/content_settings/core/browser/content_settings_provider.h - Issue 1034143002: Content settings clean-up: Clarify resource identifier & get rid of NO_RESOURCE_IDENTIFIER.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_provider.h

Issue 1034143002: Content settings clean-up: Clarify resource identifier & get rid of NO_RESOURCE_IDENTIFIER. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nit. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_policy_provider.cc ('k') | components/content_settings/core/common/content_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_provider.h

diff --git a/components/content_settings/core/browser/content_settings_provider.h b/components/content_settings/core/browser/content_settings_provider.h

index a51ed5246ac231a059940194ed74b710fa4814ec..c3e63e772398ba24b39348be1d6e50126f8cfb8f 100644

--- a/components/content_settings/core/browser/content_settings_provider.h

+++ b/components/content_settings/core/browser/content_settings_provider.h

@@ -7,12 +7,10 @@

#ifndef COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_

#define COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_

-#define NO_RESOURCE_IDENTIFIER std::string()

#include <string>

#include "base/values.h"

-#include "components/content_settings/core/common/content_settings_types.h"

+#include "components/content_settings/core/common/content_settings.h"

class ContentSettingsPattern;

@@ -21,8 +19,6 @@ namespace content_settings {

struct Rule;

class RuleIterator;

-typedef std::string ResourceIdentifier;

class ProviderInterface {

public:

virtual ~ProviderInterface() {}