Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: components/content_settings/core/browser/content_settings_provider.h

Issue 1034143002: Content settings clean-up: Clarify resource identifier & get rid of NO_RESOURCE_IDENTIFIER. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Interface for objects providing content setting rules. 5 // Interface for objects providing content setting rules.
6 6
7 #ifndef COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_ 7 #ifndef COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_
8 #define COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_ 8 #define COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_
9 9
10 #define NO_RESOURCE_IDENTIFIER std::string()
11
12 #include <string> 10 #include <string>
13 11
14 #include "base/values.h" 12 #include "base/values.h"
15 #include "components/content_settings/core/common/content_settings_types.h" 13 #include "components/content_settings/core/common/content_settings.h"
16 14
17 class ContentSettingsPattern; 15 class ContentSettingsPattern;
18 16
19 namespace content_settings { 17 namespace content_settings {
20 18
21 struct Rule; 19 struct Rule;
22 class RuleIterator; 20 class RuleIterator;
23 21
24 typedef std::string ResourceIdentifier;
25
26 class ProviderInterface { 22 class ProviderInterface {
27 public: 23 public:
28 virtual ~ProviderInterface() {} 24 virtual ~ProviderInterface() {}
29 25
30 // Returns a |RuleIterator| over the content setting rules stored by this 26 // Returns a |RuleIterator| over the content setting rules stored by this
31 // provider. If |incognito| is true, the iterator returns only the content 27 // provider. If |incognito| is true, the iterator returns only the content
32 // settings which are applicable to the incognito mode and differ from the 28 // settings which are applicable to the incognito mode and differ from the
33 // normal mode. Otherwise, it returns the content settings for the normal 29 // normal mode. Otherwise, it returns the content settings for the normal
34 // mode. The caller takes the ownership of the returned |RuleIterator|. It is 30 // mode. The caller takes the ownership of the returned |RuleIterator|. It is
35 // not allowed to call other |ProviderInterface| functions (including 31 // not allowed to call other |ProviderInterface| functions (including
(...skipping 30 matching lines...) Expand all
66 // Detaches the Provider from all Profile-related objects like PrefService. 62 // Detaches the Provider from all Profile-related objects like PrefService.
67 // This methods needs to be called before destroying the Profile. 63 // This methods needs to be called before destroying the Profile.
68 // Afterwards, none of the methods above that should only be called on the UI 64 // Afterwards, none of the methods above that should only be called on the UI
69 // thread should be called anymore. 65 // thread should be called anymore.
70 virtual void ShutdownOnUIThread() = 0; 66 virtual void ShutdownOnUIThread() = 0;
71 }; 67 };
72 68
73 } // namespace content_settings 69 } // namespace content_settings
74 70
75 #endif // COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_ 71 #endif // COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698