Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033733007: [PresentationAPI] renamed GetScreenAvailability to ListenForScreenAvailability for consistency (Closed)

Created:
5 years, 9 months ago by whywhat
Modified:
5 years, 9 months ago
Reviewers:
mark a. foltz, imcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PresentationAPI] renamed GetScreenAvailability to ListenForScreenAvailability for consistency BUG=None Committed: https://crrev.com/9b5dbea4ac95b9a923f09b7e842f7cf8c178c3a1 Cr-Commit-Position: refs/heads/master@{#322200}

Patch Set 1 #

Patch Set 2 : Updated the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M content/browser/presentation/presentation_service_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 1 15 chunks +18 lines, -18 lines 0 comments Download
M content/common/presentation/presentation_service.mojom View 1 1 chunk +6 lines, -7 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
whywhat
PTaL
5 years, 9 months ago (2015-03-25 16:55:36 UTC) #2
mark a. foltz
lgtm
5 years, 9 months ago (2015-03-25 18:24:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033733007/20001
5 years, 9 months ago (2015-03-25 18:38:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 18:52:49 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 18:53:50 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9b5dbea4ac95b9a923f09b7e842f7cf8c178c3a1
Cr-Commit-Position: refs/heads/master@{#322200}

Powered by Google App Engine
This is Rietveld 408576698