content/browser/presentation/presentation_service_impl.cc - Issue 1033733007: [PresentationAPI] renamed GetScreenAvailability to ListenForScreenAvailability for consistency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_service_impl.cc

Issue 1033733007: [PresentationAPI] renamed GetScreenAvailability to ListenForScreenAvailability for consistency (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated the test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/presentation/presentation_service_impl.h ('k') | content/browser/presentation/presentation_service_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/presentation/presentation_service_impl.cc

diff --git a/content/browser/presentation/presentation_service_impl.cc b/content/browser/presentation/presentation_service_impl.cc

index a3baa5fbdb58db504023a37a7c3f89fec68d3810..a78397836c7c9b7277f0307c3dedb59ca49fcb21 100644

--- a/content/browser/presentation/presentation_service_impl.cc

+++ b/content/browser/presentation/presentation_service_impl.cc

@@ -84,10 +84,10 @@ PresentationServiceImpl::GetOrCreateAvailabilityContext(

return it->second.get();

}

-void PresentationServiceImpl::GetScreenAvailability(

+void PresentationServiceImpl::ListenForScreenAvailability(

const mojo::String& presentation_url,

const ScreenAvailabilityMojoCallback& callback) {

- DVLOG(2) << "GetScreenAvailability";

+ DVLOG(2) << "ListenForScreenAvailability";

if (!delegate_) {

callback.Run(presentation_url, false);

return;

@@ -102,9 +102,9 @@ void PresentationServiceImpl::GetScreenAvailability(

context->CallbackReceived(callback);

}

-void PresentationServiceImpl::OnScreenAvailabilityListenerRemoved(

+void PresentationServiceImpl::RemoveScreenAvailabilityListener(

const mojo::String& presentation_url) {

- DVLOG(2) << "OnScreenAvailabilityListenerRemoved";

+ DVLOG(2) << "RemoveScreenAvailabilityListener";

if (!delegate_)

return;