Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1033493003: [Telemetry] Remove Page.TransferToPageSet method. (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove Page.TransferToPageSet method. This method is never used. It was introduced as a way to conveniently share pages among page sets. The implementation is not correct as archive_data_file is defined in page_set. In the future, sharing pages among pageset should be simple when we can remove the page's dependence on pageset (https://code.google.com/p/chromium/issues/detail?id=466836) Committed: https://crrev.com/654481e2ebabb556baf92e5003c7a32d84a8b05b Cr-Commit-Position: refs/heads/master@{#322661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M tools/telemetry/telemetry/page/__init__.py View 1 chunk +0 lines, -20 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
5 years, 9 months ago (2015-03-26 16:04:38 UTC) #2
nednguyen
ping
5 years, 9 months ago (2015-03-27 20:50:04 UTC) #3
aiolos (Not reviewing)
lgtm.
5 years, 9 months ago (2015-03-27 21:35:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033493003/1
5 years, 9 months ago (2015-03-27 21:42:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 22:37:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 22:38:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/654481e2ebabb556baf92e5003c7a32d84a8b05b
Cr-Commit-Position: refs/heads/master@{#322661}

Powered by Google App Engine
This is Rietveld 408576698