Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: tools/telemetry/telemetry/page/__init__.py

Issue 1033493003: [Telemetry] Remove Page.TransferToPageSet method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/__init__.py
diff --git a/tools/telemetry/telemetry/page/__init__.py b/tools/telemetry/telemetry/page/__init__.py
index 8aa65abeba0e3fb0f42b84206566ec72b4b064cd..d0a6578fd125679461ddc3fb0490aa062076c348 100644
--- a/tools/telemetry/telemetry/page/__init__.py
+++ b/tools/telemetry/telemetry/page/__init__.py
@@ -76,26 +76,6 @@ class Page(user_story.UserStory):
if startup_url_scheme == 'file':
raise ValueError('startup_url with local file scheme is not supported')
- def TransferToPageSet(self, another_page_set):
- """ Transfer this page to another page set.
- Args:
- another_page_set: an instance of telemetry.page.PageSet to transfer this
- page to.
- Note:
- This method removes this page instance from the pages list of its current
- page_set, so one should be careful not to iterate through the list of
- pages of a page_set and calling this method.
- For example, the below loop is erroneous:
- for p in page_set_A.pages:
- p.TransferToPageSet(page_set_B.pages)
- """
- assert self._page_set
- if another_page_set is self._page_set:
- return
- self._page_set.pages.remove(self)
- self._page_set = another_page_set
- self._page_set.AddUserStory(self)
-
def RunNavigateSteps(self, action_runner):
url = self.file_path_url_with_scheme if self.is_file else self.url
action_runner.Navigate(
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698