Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: components/metrics/net/network_metrics_provider.h

Issue 1033493002: Histogram for UMA log upload connection type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/net/network_metrics_provider.h
diff --git a/components/metrics/net/network_metrics_provider.h b/components/metrics/net/network_metrics_provider.h
index ffdc017d98fe0ccd3d3e601a2b7a38cad2c9c857..f1956a8037927ab26e581471b5fbd17939362e8d 100644
--- a/components/metrics/net/network_metrics_provider.h
+++ b/components/metrics/net/network_metrics_provider.h
@@ -31,6 +31,11 @@ class NetworkMetricsProvider
// can be used to get whether current connection type is cellular.
base::Callback<void(bool*)> GetConnectionCallback();
+ // Returns true if the connection type is 2G, 3G, or 4G.
+ bool IsCellularConnection() const;
+
+ SystemProfileProto::Network::ConnectionType GetConnectionType() const;
+
private:
// MetricsProvider:
void OnDidCreateMetricsLog() override;
@@ -40,7 +45,6 @@ class NetworkMetricsProvider
void OnConnectionTypeChanged(
net::NetworkChangeNotifier::ConnectionType type) override;
- SystemProfileProto::Network::ConnectionType GetConnectionType() const;
SystemProfileProto::Network::WifiPHYLayerProtocol GetWifiPHYLayerProtocol()
const;
@@ -56,9 +60,6 @@ class NetworkMetricsProvider
const WifiAccessPointInfoProvider::WifiAccessPointInfo& info,
SystemProfileProto::Network* network_proto);
- // Returns true if the connection type is 2G, 3G, or 4G.
- bool IsCellularConnection();
-
// Assigns the passed |is_cellular_out| parameter based on whether current
// network connection is cellular.
void GetIsCellularConnection(bool* is_cellular_out);

Powered by Google App Engine
This is Rietveld 408576698