components/metrics/metrics_service_client.h - Issue 1033493002: Histogram for UMA log upload connection type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service_client.h

Issue 1033493002: Histogram for UMA log upload connection type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/metrics_service_client.h

diff --git a/components/metrics/metrics_service_client.h b/components/metrics/metrics_service_client.h

index 1b481f998830ad4fdf746adfde3213e8e0107ccd..154f369b4d2c011802c67ba50c7b2b0aa9a40ebf 100644

--- a/components/metrics/metrics_service_client.h

+++ b/components/metrics/metrics_service_client.h

@@ -51,7 +51,7 @@ class MetricsServiceClient {

virtual std::string GetVersionString() = 0;

// Called by the metrics service when a log has been uploaded.

Ilya Sherman 2015/03/24 00:14:23 Please update the documentation for this method.

gayane -on leave until 09-2017 2015/03/24 20:45:55 Done.

- virtual void OnLogUploadComplete() = 0;

+ virtual void OnLogUploadComplete(bool upload_succeeded) = 0;

// Starts gathering metrics, calling |done_callback| when initial metrics

// gathering is complete.