GuestView: Lazily push attributes to the browser process on attach

GuestView: Lazily push attributes to the browser process on attach

Only push attributes to the browser process on attach that have changed
since create.

This CL also allows partial changes to autosize parameters.

BUG=471402
Committed: https://crrev.com/1d139b208626492b3bcdd50a43902d6c91481d27
Cr-Commit-Position: refs/heads/master@{#322683}

[Fady Samuel, 2015-03-27 22:27:29]

fsamuel@chromium.org changed reviewers:
+ paulmeyer@chromium.org

[paulmeyer, 2015-03-27 22:40:41]

I'm confused about the bug listed with this patch. How are these changes related
to that bug?

https://codereview.chromium.org/1033373003/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/1033373003/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/guest_view_base.cc:787: SetSizeParams
set_size_params;
Why is set_size_params declared up here now?

https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
(right):

https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/web_view/web_view_attributes.js:202:
GuestViewAttributes.Attribute.prototype.attach.call(this);
Why are these calls to the base attach/detach needed?

https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/web_view/web_view_attributes.js:207:
GuestViewAttributes.Attribute.prototype.detach.call(this);
See above.

[Fady Samuel, 2015-03-27 22:56:36]

I couldn't find the right bug so I filed a new one. Thanks! PTAL

https://codereview.chromium.org/1033373003/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/1033373003/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/guest_view_base.cc:787: SetSizeParams
set_size_params;
On 2015/03/27 22:40:40, Paul Meyer wrote:
> Why is set_size_params declared up here now?

Done.

https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
(right):

https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/web_view/web_view_attributes.js:202:
GuestViewAttributes.Attribute.prototype.attach.call(this);
On 2015/03/27 22:40:40, Paul Meyer wrote:
> Why are these calls to the base attach/detach needed?

They're unnecessary. They're remnants from an older approach I tried. Thanks for
catching that!

https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/web_view/web_view_attributes.js:207:
GuestViewAttributes.Attribute.prototype.detach.call(this);
On 2015/03/27 22:40:40, Paul Meyer wrote:
> See above.

Done.

[paulmeyer, 2015-03-27 22:59:09]

On 2015/03/27 22:56:36, Fady Samuel wrote:
> I couldn't find the right bug so I filed a new one. Thanks! PTAL
> 
>
https://codereview.chromium.org/1033373003/diff/1/extensions/browser/guest_vi...
> File extensions/browser/guest_view/guest_view_base.cc (right):
> 
>
https://codereview.chromium.org/1033373003/diff/1/extensions/browser/guest_vi...
> extensions/browser/guest_view/guest_view_base.cc:787: SetSizeParams
> set_size_params;
> On 2015/03/27 22:40:40, Paul Meyer wrote:
> > Why is set_size_params declared up here now?
> 
> Done.
> 
>
https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
> File extensions/renderer/resources/guest_view/web_view/web_view_attributes.js
> (right):
> 
>
https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
> extensions/renderer/resources/guest_view/web_view/web_view_attributes.js:202:
> GuestViewAttributes.Attribute.prototype.attach.call(this);
> On 2015/03/27 22:40:40, Paul Meyer wrote:
> > Why are these calls to the base attach/detach needed?
> 
> They're unnecessary. They're remnants from an older approach I tried. Thanks
for
> catching that!
> 
>
https://codereview.chromium.org/1033373003/diff/1/extensions/renderer/resourc...
> extensions/renderer/resources/guest_view/web_view/web_view_attributes.js:207:
> GuestViewAttributes.Attribute.prototype.detach.call(this);
> On 2015/03/27 22:40:40, Paul Meyer wrote:
> > See above.
> 
> Done.

LGTM!

[Fady Samuel, 2015-03-27 23:15:35]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-03-27 23:15:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1033373003/40001

[commit-bot: I haz the power, 2015-03-28 00:09:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-28 00:10:30]

Patchset 3 (id:??) landed as
https://crrev.com/1d139b208626492b3bcdd50a43902d6c91481d27
Cr-Commit-Position: refs/heads/master@{#322683}