GuestView: Lazily push attributes to the browser process on attach

extensions/browser/guest_view/guest_view_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/guest_view_base.h"
 
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/ui/zoom/page_zoom.h"
 #include "components/ui/zoom/zoom_controller.h"
@@ skipping 766 matching lines @@
       ui_zoom::ZoomController::FromWebContents(embedder_web_contents());
   if (!zoom_controller)
     return 1.0;
 
   double zoom_factor =
       content::ZoomLevelToZoomFactor(zoom_controller->GetZoomLevel());
   return zoom_factor;
 }
 
 void GuestViewBase::SetUpSizing(const base::DictionaryValue& params) {
+  SetSizeParams set_size_params;

[paulmeyer, 2015/03/27 22:40:40]

Why is set_size_params declared up here now?

[Fady Samuel, 2015/03/27 22:56:36]

Done.

   // Read the autosize parameters passed in from the embedder.
-  bool auto_size_enabled = false;
+  bool auto_size_enabled = auto_size_enabled_;
   params.GetBoolean(guestview::kAttributeAutoSize, &auto_size_enabled);
 
-  int max_height = 0;
-  int max_width = 0;
+  int max_height = max_auto_size_.height();
+  int max_width = max_auto_size_.width();
   params.GetInteger(guestview::kAttributeMaxHeight, &max_height);
   params.GetInteger(guestview::kAttributeMaxWidth, &max_width);
 
-  int min_height = 0;
-  int min_width = 0;
+  int min_height = min_auto_size_.height();
+  int min_width = min_auto_size_.width();
   params.GetInteger(guestview::kAttributeMinHeight, &min_height);
   params.GetInteger(guestview::kAttributeMinWidth, &min_width);
 
-  int normal_height = 0;
-  int normal_width = 0;
+  int normal_height = normal_size_.height();
+  int normal_width = normal_size_.width();
   if (is_full_page_plugin()) {
     // The initial size of a full page plugin should be set to fill the
     // owner's visible viewport.
     auto owner_size = owner_web_contents()->GetRenderWidgetHostView()->
         GetVisibleViewportSize();
     normal_height = owner_size.height();
     normal_width = owner_size.width();
   } else {
     // Set the normal size to the element size so that the guestview will fit
     // the element initially if autosize is disabled.
@@ skipping 10 matching lines @@
     if (element_size_is_logical) {
       // Convert the element size from logical pixels to physical pixels.
       normal_height = LogicalPixelsToPhysicalPixels(element_height);
       normal_width = LogicalPixelsToPhysicalPixels(element_width);
     } else {
       normal_height = lround(element_height);
       normal_width = lround(element_width);
     }
   }
 
-  SetSizeParams set_size_params;
   set_size_params.enable_auto_size.reset(new bool(auto_size_enabled));
   set_size_params.min_size.reset(new gfx::Size(min_width, min_height));
   set_size_params.max_size.reset(new gfx::Size(max_width, max_height));
   set_size_params.normal_size.reset(new gfx::Size(normal_width, normal_height));
 
   // Call SetSize to apply all the appropriate validation and clipping of
   // values.
   SetSize(set_size_params);
 }
 
@@ skipping 39 matching lines @@
 void GuestViewBase::RegisterGuestViewTypes() {
   AppViewGuest::Register();
   ExtensionOptionsGuest::Register();
   ExtensionViewGuest::Register();
   MimeHandlerViewGuest::Register();
   SurfaceWorkerGuest::Register();
   WebViewGuest::Register();
 }
 
 }  // namespace extensions