Supervised users: Don't URLEscape extension update requests

Supervised users: Don't URLEscape extension update requests

Before, the colon in "extensionid:version" would get escaped, leading to
confusion all around

BUG=397951
Committed: https://crrev.com/1dc04bbeb5caf69a737aca89e69ba2898b1e4180
Cr-Commit-Position: refs/heads/master@{#322576}

[Marc Treib, 2015-03-27 11:56:45]

treib@chromium.org changed reviewers:
+ pam@chromium.org

[Pam (message me for reviews), 2015-03-27 12:13:54]

LGTM, one comment request

https://codereview.chromium.org/1033253002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
(right):

https://codereview.chromium.org/1033253002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc:69: //
Add the prefix.
Please add a note to the corresponding .h file mentioning that callers are
responsible for escaping the data.

[Marc Treib, 2015-03-27 12:19:16]

https://codereview.chromium.org/1033253002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
(right):

https://codereview.chromium.org/1033253002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc:69: //
Add the prefix.
On 2015/03/27 12:13:54, Pam (also PM for reviews) wrote:
> Please add a note to the corresponding .h file mentioning that callers are
> responsible for escaping the data.

This is a private method. CreateURLAccessRequest above is the public one, and
that one still does the escaping.

[Marc Treib, 2015-03-27 12:30:57]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2015-03-27 12:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1033253002/1

[commit-bot: I haz the power, 2015-03-27 14:41:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-27 14:42:35]

Patchset 1 (id:??) landed as
https://crrev.com/1dc04bbeb5caf69a737aca89e69ba2898b1e4180
Cr-Commit-Position: refs/heads/master@{#322576}

[Pam (message me for reviews), 2015-03-27 20:22:04]

On 2015/03/27 12:19:16, Marc Treib wrote:
>
https://codereview.chromium.org/1033253002/diff/1/chrome/browser/supervised_u...
> File chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
> (right):
> 
>
https://codereview.chromium.org/1033253002/diff/1/chrome/browser/supervised_u...
> chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc:69:
//
> Add the prefix.
> On 2015/03/27 12:13:54, Pam (also PM for reviews) wrote:
> > Please add a note to the corresponding .h file mentioning that callers are
> > responsible for escaping the data.
> 
> This is a private method. CreateURLAccessRequest above is the public one, and
> that one still does the escaping.

It's a private method, but that doesn't mean someone coming along in a year,
adding some new kind of permission request, will necessarily read the
implementation carefully.