Supervised users: Don't URLEscape extension update requests

chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

Index: chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
diff --git a/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc b/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
index e91d236f621be96cce5c902aad1927ab170eccd8..25c4ab613b829903492e0b3c09d3fdc74cf2f147 100644
--- a/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
+++ b/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
@@ -52,7 +52,7 @@ void PermissionRequestCreatorSync::CreateURLAccessRequest(
     const GURL& url_requested,
     const SuccessCallback& callback) {
   CreateRequest(kSupervisedUserAccessRequestKeyPrefix,
-                url_requested.spec(),
+                net::EscapeQueryParamValue(url_requested.spec(), true),
                 callback);
 }
 
@@ -66,10 +66,9 @@ void PermissionRequestCreatorSync::CreateRequest(
     const std::string& prefix,
     const std::string& data,
     const SuccessCallback& callback) {
-  // Escape the data string and add the prefix.
-  std::string key = SupervisedUserSettingsService::MakeSplitSettingKey(
-      prefix,
-      net::EscapeQueryParamValue(data, true));
+  // Add the prefix.

[Pam (message me for reviews), 2015/03/27 12:13:54]

Please add a note to the corresponding .h file mentioning that callers are
responsible for escaping the data.

[Marc Treib, 2015/03/27 12:19:16]

This is a private method. CreateURLAccessRequest above is the public one, and
that one still does the escaping.

+  std::string key =
+      SupervisedUserSettingsService::MakeSplitSettingKey(prefix, data);
 
   scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
   // TODO(sergiu): Use sane time here when it's ready.