Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1032893002: media: VideoRendererImpl: fix unit test on DrMemory bots (Closed)

Created:
5 years, 9 months ago by llandwerlin-old
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: VideoRendererImpl: fix unit test on DrMemory bots BUG=470517 Committed: https://crrev.com/8a46ab616724aade182bc285018e7c0b0f8aee86 Cr-Commit-Position: refs/heads/master@{#322547}

Patch Set 1 #

Patch Set 2 : remove test from exclude list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/renderers/video_renderer_impl_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
D tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
llandwerlin-old
I can't actually test this on the DrMemory bots, so I'm guessing this is where ...
5 years, 9 months ago (2015-03-25 18:16:44 UTC) #2
DaleCurtis
Patch didn't seem to upload correctly, can you resend?
5 years, 9 months ago (2015-03-25 20:18:31 UTC) #3
llandwerlin-old
On 2015/03/25 20:18:31, DaleCurtis wrote: > Patch didn't seem to upload correctly, can you resend? ...
5 years, 9 months ago (2015-03-26 10:30:21 UTC) #4
DaleCurtis
lgtm
5 years, 9 months ago (2015-03-26 17:09:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032893002/20001
5 years, 9 months ago (2015-03-26 17:11:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/10181)
5 years, 9 months ago (2015-03-26 18:09:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032893002/20001
5 years, 9 months ago (2015-03-27 10:44:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 10:52:02 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8a46ab616724aade182bc285018e7c0b0f8aee86 Cr-Commit-Position: refs/heads/master@{#322547}
5 years, 9 months ago (2015-03-27 10:53:04 UTC) #13
earthdok
5 years, 9 months ago (2015-03-27 16:06:42 UTC) #14
Message was sent while issue was closed.
On 2015/03/27 10:53:04, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/8a46ab616724aade182bc285018e7c0b0f8aee86
> Cr-Commit-Position: refs/heads/master@{#322547}

Still failing:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

Please add back to excludes until fixed.

Powered by Google App Engine
This is Rietveld 408576698