Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: media/renderers/video_renderer_impl_unittest.cc

Issue 1032893002: media: VideoRendererImpl: fix unit test on DrMemory bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove test from exclude list Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/video_renderer_impl_unittest.cc
diff --git a/media/renderers/video_renderer_impl_unittest.cc b/media/renderers/video_renderer_impl_unittest.cc
index 54ca695c1c199de79676236fd21faa9d133e207a..5e562a0de0deaa917790c484f21355565f68a64f 100644
--- a/media/renderers/video_renderer_impl_unittest.cc
+++ b/media/renderers/video_renderer_impl_unittest.cc
@@ -26,6 +26,7 @@
using ::testing::_;
using ::testing::AnyNumber;
using ::testing::Invoke;
+using ::testing::Mock;
using ::testing::NiceMock;
using ::testing::Return;
using ::testing::SaveArg;
@@ -481,6 +482,7 @@ TEST_F(VideoRendererImplTest, Underflow) {
EXPECT_CALL(mock_cb_, BufferingStateChange(BUFFERING_HAVE_ENOUGH));
StartPlayingFrom(0);
event.RunAndWait();
+ Mock::VerifyAndClearExpectations(&mock_cb_);
}
// Advance time slightly. Frames should be dropped and we should NOT signal
@@ -499,6 +501,7 @@ TEST_F(VideoRendererImplTest, Underflow) {
EXPECT_CALL(mock_cb_, Display(HasTimestamp(30))).Times(1);
AdvanceTimeInMs(3000); // Must match kTimeToDeclareHaveNothing.
event.RunAndWait();
+ Mock::VerifyAndClearExpectations(&mock_cb_);
}
// Receiving end of stream should signal having enough.
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698