Source/core/page/ContextMenuController.cpp - Issue 1032823003: Refactor HitTestResult to store the HitTestRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ContextMenuController.cpp

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/svg/LayoutSVGResourceClipper.cpp ('K') | « Source/core/layout/svg/line/SVGInlineTextBox.cpp ('k') | Source/core/page/DragController.cpp » ('j') | Source/core/page/DragController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/ContextMenuController.cpp

diff --git a/Source/core/page/ContextMenuController.cpp b/Source/core/page/ContextMenuController.cpp

index f8ad4daf9dc1ead2c8491578791b92ee60b4a774..5b04e121b148d809f30014945242c565be84c9df 100644

--- a/Source/core/page/ContextMenuController.cpp

+++ b/Source/core/page/ContextMenuController.cpp

@@ -158,7 +158,8 @@ PassOwnPtr<ContextMenu> ContextMenuController::createContextMenu(Event* event)

PassOwnPtr<ContextMenu> ContextMenuController::createContextMenu(LocalFrame* frame, const LayoutPoint& location)

{

- HitTestResult result(location);

+ HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::Active);

+ HitTestResult result(request, location);

if (frame)

result = frame->eventHandler().hitTestResultAtPoint(location, HitTestRequest::ReadOnly | HitTestRequest::Active);

Rick Byers 2015/03/31 00:51:00 nit: pass 'request' here rather than specify this

ramya.v 2015/03/31 09:41:36 Done.