Source/core/layout/svg/LayoutSVGResourceClipper.cpp - Issue 1032823003: Refactor HitTestResult to store the HitTestRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/LayoutSVGResourceClipper.cpp

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/LocalFrame.cpp ('K') | « Source/core/layout/svg/LayoutSVGModelObject.cpp ('k') | Source/core/layout/svg/LayoutSVGRoot.h » ('j') | Source/core/page/ContextMenuController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/svg/LayoutSVGResourceClipper.cpp

diff --git a/Source/core/layout/svg/LayoutSVGResourceClipper.cpp b/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

index 6310705d8360ca8bd2c25c9031ac200554994a0a..373576e484fd9989c6f3f7b05f9c9825685a4de3 100644

--- a/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

+++ b/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

@@ -247,8 +247,9 @@ bool LayoutSVGResourceClipper::hitTestClipContent(const FloatRect& objectBoundin

if (!layoutObject->isSVGShape() && !layoutObject->isSVGText() && !isSVGUseElement(*childElement))

continue;

IntPoint hitPoint;

- HitTestResult result(hitPoint);

- if (layoutObject->nodeAtFloatPoint(HitTestRequest(HitTestRequest::SVGClipContent), result, point, HitTestForeground))

+ HitTestRequest request(HitTestRequest::SVGClipContent);

+ HitTestResult result(request, hitPoint);

Rick Byers 2015/03/31 00:51:00 nit: might as well just put this inline rather tha

ramya.v 2015/03/31 09:41:36 Done.

+ if (layoutObject->nodeAtFloatPoint(result, point, HitTestForeground))

return true;

}