Source/core/layout/LayoutTextControlMultiLine.h - Issue 1032823003: Refactor HitTestResult to store the HitTestRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTextControlMultiLine.h

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/LocalFrame.cpp ('K') | « Source/core/layout/LayoutText.h ('k') | Source/core/layout/LayoutTextControlMultiLine.cpp » ('j') | Source/core/layout/svg/LayoutSVGResourceClipper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutTextControlMultiLine.h

diff --git a/Source/core/layout/LayoutTextControlMultiLine.h b/Source/core/layout/LayoutTextControlMultiLine.h

index 144fa228250a9c1b6644b5154affcc75348d35fc..6fdb70aba1819791708708ec2578d84bd1bebb9e 100644

--- a/Source/core/layout/LayoutTextControlMultiLine.h

+++ b/Source/core/layout/LayoutTextControlMultiLine.h

@@ -36,7 +36,7 @@ public:

private:

virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectTextArea || LayoutTextControl::isOfType(type); }

- virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;

+ virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;

virtual float getAvgCharWidth(AtomicString family) override;

virtual LayoutUnit preferredContentLogicalWidth(float charWidth) const override;