Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp
index 01956b200e8497098081240dc3b9296d3ba30d7f..c1ad64827b30f66c9b858db8815bf74ea6dbb0eb 100644
--- a/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/Source/core/inspector/InspectorDOMAgent.cpp
@@ -158,8 +158,8 @@ static Node* hoveredNodeForPoint(LocalFrame* frame, const IntPoint& pointInRootF
if (ignorePointerEventsNone)
hitType |= HitTestRequest::IgnorePointerEventsNone;
HitTestRequest request(hitType);
- HitTestResult result(frame->view()->rootFrameToContents(pointInRootFrame));
- frame->contentRenderer()->hitTest(request, result);
+ HitTestResult result(request, frame->view()->rootFrameToContents(pointInRootFrame));
+ frame->contentRenderer()->hitTest(result);
Node* node = result.innerPossiblyPseudoNode();
while (node && node->nodeType() == Node::TEXT_NODE)
node = node->parentNode();
@@ -1533,8 +1533,8 @@ void InspectorDOMAgent::getNodeForLocation(ErrorString* errorString, int x, int
if (!pushDocumentUponHandlelessOperation(errorString))
return;
HitTestRequest request(HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::AllowChildFrameContent);
- HitTestResult result(IntPoint(x, y));
- m_document->frame()->contentRenderer()->hitTest(request, result);
+ HitTestResult result(request, IntPoint(x, y));
+ m_document->frame()->contentRenderer()->hitTest(result);
Node* node = result.innerPossiblyPseudoNode();
while (node && node->nodeType() == Node::TEXT_NODE)
node = node->parentNode();

Powered by Google App Engine
This is Rietveld 408576698