Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1032553009: favor DCHECK_CURRENTLY_ON for better logs in extensions/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in extensions/ BUG=466848 Committed: https://crrev.com/f84bb8f4702438347971a24e964d7ee15c1702ef Cr-Commit-Position: refs/heads/master@{#322238}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Jeffrey: PTAL.
5 years, 9 months ago (2015-03-25 19:59:36 UTC) #2
Jeffrey Yasskin
LGTM, thanks!
5 years, 9 months ago (2015-03-25 20:13:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032553009/1
5 years, 9 months ago (2015-03-25 20:15:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 21:39:50 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 21:40:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f84bb8f4702438347971a24e964d7ee15c1702ef
Cr-Commit-Position: refs/heads/master@{#322238}

Powered by Google App Engine
This is Rietveld 408576698