extensions/browser/guest_view/guest_view_message_filter.cc - Issue 1032553009: favor DCHECK_CURRENTLY_ON for better logs in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_message_filter.cc

Issue 1032553009: favor DCHECK_CURRENTLY_ON for better logs in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc ('k') | extensions/shell/browser/shell_speech_recognition_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_message_filter.cc

diff --git a/extensions/browser/guest_view/guest_view_message_filter.cc b/extensions/browser/guest_view/guest_view_message_filter.cc

index 52f8d6bc9297fd127c4e7d774737bd938e5adcb7..e7c505c43d41af08114cb94df061653f1201279e 100644

--- a/extensions/browser/guest_view/guest_view_message_filter.cc

+++ b/extensions/browser/guest_view/guest_view_message_filter.cc

@@ -70,7 +70,7 @@ void GuestViewMessageFilter::OnAttachGuest(

int element_instance_id,

int guest_instance_id,

const base::DictionaryValue& params) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

auto manager = GuestViewManager::FromBrowserContext(browser_context_);

if (!manager)

return;

@@ -86,7 +86,7 @@ void GuestViewMessageFilter::OnCreateMimeHandlerViewGuest(

const std::string& view_id,