Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 103253005: Revert 240887 "Revert 240885 "Revert 240883 "Refactor audio mana..." (Closed)

Created:
7 years ago by szym
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 240887 "Revert 240885 "Revert 240883 "Refactor audio mana..." The introduced test media_unittests: VideoCaptureDeviceTest.GetDeviceSupportedFormats crashes on main waterfall [FATAL:jni_android.cc(216)] Check failed: false. > Revert 240885 "Revert 240883 "Refactor audio manager for Android..." > > > Revert 240883 "Refactor audio manager for Android to avoid heavy..." > > > > > Refactor audio manager for Android to avoid heavy tasks at startup. > > > > > > Main goal of this CL is to avoid all demanding tasks (e.g. initiate audio routing, detect BT devices etc.) at Chrome startup. > > > > > > All we do now is to populate the list of available devices. BT support has been removed but will be added in an upcoming CL. Detection will not require BLUETOOTH permission. > > > > > > BUG=324464 > > > TEST=media_unittests --gtest-filter=AudioAndroid* > > > R=bulach@chromium.org, tommi@chromium.org > > > > > > Review URL: https://codereview.chromium.org/110173003 > > > > TBR=henrika@chromium.org > > > > Review URL: https://codereview.chromium.org/105893005 > > TBR=henrika@chromium.org > > Review URL: https://codereview.chromium.org/102613007 TBR=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -306 lines) Patch
M trunk/src/build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/media/audio/android/audio_android_unittest.cc View 2 chunks +0 lines, -53 lines 0 comments Download
M trunk/src/media/audio/android/audio_manager_android.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/media/audio/android/audio_manager_android.cc View 7 chunks +16 lines, -40 lines 0 comments Download
M trunk/src/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 21 chunks +220 lines, -210 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
szym
7 years ago (2013-12-16 17:57:02 UTC) #1
szym
7 years ago (2013-12-16 17:57:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r240917.

Powered by Google App Engine
This is Rietveld 408576698