Issue 105893005: Revert 240883 "Refactor audio manager for Android to avoid heavy..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105893005: Revert 240883 "Refactor audio manager for Android to avoid heavy..." (Closed)

Created:
7 years ago by henrika (OOO until Aug 14)

Modified:
7 years ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 240883 "Refactor audio manager for Android to avoid heavy..." > Refactor audio manager for Android to avoid heavy tasks at startup. > > Main goal of this CL is to avoid all demanding tasks (e.g. initiate audio routing, detect BT devices etc.) at Chrome startup. > > All we do now is to populate the list of available devices. BT support has been removed but will be added in an upcoming CL. Detection will not require BLUETOOTH permission. > > BUG=324464 > TEST=media_unittests --gtest-filter=AudioAndroid* > R=bulach@chromium.org, tommi@chromium.org > > Review URL: https://codereview.chromium.org/110173003 TBR=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240885

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+240 lines, -306 lines)			Patch
M	trunk/src/build/android/findbugs_filter/findbugs_known_bugs.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/media/audio/android/audio_android_unittest.cc	View	2 chunks	+0 lines, -53 lines	0 comments	Download
M	trunk/src/media/audio/android/audio_manager_android.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/media/audio/android/audio_manager_android.cc	View	7 chunks	+16 lines, -40 lines	0 comments	Download
M	trunk/src/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java	View	21 chunks	+220 lines, -210 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r240885.

Expand Messages | Collapse Messages