Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 103253004: Remove Chrome Frame quick-enable. (Closed)

Created:
7 years ago by grt (UTC plus 2)
Modified:
7 years ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Remove Chrome Frame quick-enable. BUG=316496 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241116

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -510 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/installer/setup/chrome_frame_quick_enable.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/installer/setup/chrome_frame_quick_enable.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M chrome/installer/setup/install_worker.h View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 2 chunks +7 lines, -37 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 1 chunk +2 lines, -171 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 2 chunks +1 line, -20 lines 0 comments Download
M chrome/installer/util/installation_validator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/installation_validator.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M chrome/installer/util/util_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/util_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
grt (UTC plus 2)
7 years ago (2013-12-16 16:41:02 UTC) #1
robertshield
lgtm https://codereview.chromium.org/103253004/diff/1/chrome/installer/setup/install_worker.cc File chrome/installer/setup/install_worker.cc (right): https://codereview.chromium.org/103253004/diff/1/chrome/installer/setup/install_worker.cc#newcode1523 chrome/installer/setup/install_worker.cc:1523: // Do this even if multi-install Chrome isn't ...
7 years ago (2013-12-16 16:50:12 UTC) #2
grt (UTC plus 2)
thanks. https://codereview.chromium.org/103253004/diff/1/chrome/installer/setup/install_worker.cc File chrome/installer/setup/install_worker.cc (right): https://codereview.chromium.org/103253004/diff/1/chrome/installer/setup/install_worker.cc#newcode1523 chrome/installer/setup/install_worker.cc:1523: // Do this even if multi-install Chrome isn't ...
7 years ago (2013-12-16 17:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/103253004/20001
7 years ago (2013-12-16 17:56:42 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204973
7 years ago (2013-12-16 19:30:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/103253004/20001
7 years ago (2013-12-16 19:53:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205149
7 years ago (2013-12-16 23:02:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/103253004/20001
7 years ago (2013-12-16 23:25:58 UTC) #8
grt (UTC plus 2)
attempting to land with NOTRY=true to get around unrelated breakage in browser_tests.
7 years ago (2013-12-17 02:07:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/103253004/20001
7 years ago (2013-12-17 02:20:44 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-17 02:28:19 UTC) #11
Message was sent while issue was closed.
Change committed as 241116

Powered by Google App Engine
This is Rietveld 408576698