Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3991)

Unified Diff: chrome/installer/util/installation_validator.cc

Issue 103253004: Remove Chrome Frame quick-enable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/installation_validator.cc
diff --git a/chrome/installer/util/installation_validator.cc b/chrome/installer/util/installation_validator.cc
index 87fb66eb8d75405158e40aa93dafb3faf8f44791..9123ca4b9dea5e307d881defcb6f607830146d85 100644
--- a/chrome/installer/util/installation_validator.cc
+++ b/chrome/installer/util/installation_validator.cc
@@ -314,35 +314,6 @@ void InstallationValidator::ValidateQueryEULAAcceptanceCommand(
ValidateAppCommandFlags(ctx, app_cmd, flags_exp, name, is_valid);
}
-// Validates the "quick-enable-cf" Google Update product command.
-void InstallationValidator::ValidateQuickEnableCfCommand(
- const ProductContext& ctx,
- const AppCommand& app_cmd,
- bool* is_valid) {
- DCHECK(is_valid);
-
- CommandLine cmd_line(CommandLine::FromString(app_cmd.command_line()));
- string16 name(kCmdQuickEnableCf);
-
- ValidateSetupPath(ctx, cmd_line.GetProgram(), name, is_valid);
-
- SwitchExpectations expected;
-
- expected.push_back(
- std::make_pair(std::string(switches::kChromeFrameQuickEnable), true));
- expected.push_back(std::make_pair(std::string(switches::kSystemLevel),
- ctx.system_install));
- expected.push_back(std::make_pair(std::string(switches::kMultiInstall),
- ctx.state.is_multi_install()));
-
- ValidateCommandExpectations(ctx, cmd_line, expected, name, is_valid);
-
- std::set<string16> flags_exp;
- flags_exp.insert(google_update::kRegSendsPingsField);
- flags_exp.insert(google_update::kRegWebAccessibleField);
- ValidateAppCommandFlags(ctx, app_cmd, flags_exp, name, is_valid);
-}
-
// Validates the "quick-enable-application-host" Google Update product command.
void InstallationValidator::ValidateQuickEnableApplicationHostCommand(
const ProductContext& ctx,
@@ -421,20 +392,12 @@ void InstallationValidator::ValidateBinariesCommands(
bool* is_valid) {
DCHECK(is_valid);
- // The quick-enable-cf command must be present if Chrome Binaries are
- // installed and Chrome Frame is not installed.
- const ChannelInfo& channel = ctx.state.channel();
const ProductState* binaries_state = ctx.machine_state.GetProductState(
ctx.system_install, BrowserDistribution::CHROME_BINARIES);
- const ProductState* cf_state = ctx.machine_state.GetProductState(
- ctx.system_install, BrowserDistribution::CHROME_FRAME);
CommandExpectations expectations;
if (binaries_state != NULL) {
- if (cf_state == NULL)
- expectations[kCmdQuickEnableCf] = &ValidateQuickEnableCfCommand;
-
expectations[kCmdQuickEnableApplicationHost] =
&ValidateQuickEnableApplicationHostCommand;
« no previous file with comments | « chrome/installer/util/installation_validator.h ('k') | chrome/installer/util/installation_validator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698