Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1032353004: Fix accessibility problem for ExpandablePreferenceGroup. (Closed)

Created:
5 years, 9 months ago by Finnur
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix accessibility problem for ExpandablePreferenceGroup. BUG=467552 Committed: https://crrev.com/fb0f3aa44bd2990c8567db36a553dc9985ff7982 Cr-Commit-Position: refs/heads/master@{#322549}

Patch Set 1 #

Patch Set 2 : Missing string rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Finnur
What do you think of this approach?
5 years, 9 months ago (2015-03-26 15:56:58 UTC) #2
newt (away)
lgtm
5 years, 9 months ago (2015-03-26 17:36:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032353004/20001
5 years, 9 months ago (2015-03-27 10:52:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 11:03:11 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 11:04:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb0f3aa44bd2990c8567db36a553dc9985ff7982
Cr-Commit-Position: refs/heads/master@{#322549}

Powered by Google App Engine
This is Rietveld 408576698