chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java - Issue 1032353004: Fix accessibility problem for ExpandablePreferenceGroup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java

Issue 1032353004: Fix accessibility problem for ExpandablePreferenceGroup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missing string rename Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java

index 797fac7823a82b2bf2f33fe2558089a168db30cd..9b2ccf8257f231f84b0b4bd985bba0680e08e1d1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java

@@ -243,6 +243,7 @@ public class WebsitePreferences extends PreferenceFragment

allowedGroup.setGroupTitle(resourceId, numAllowed);

TintedDrawable icon = TintedDrawable.constructTintedDrawable(getResources(),

mAllowListExpanded ? R.drawable.ic_expand : R.drawable.ic_collapse);

+ allowedGroup.setExpanded(mAllowListExpanded);

allowedGroup.setIcon(icon);

}

@@ -259,6 +260,7 @@ public class WebsitePreferences extends PreferenceFragment

blockedGroup.setGroupTitle(R.string.website_settings_blocked_group_heading, numBlocked);

TintedDrawable icon = TintedDrawable.constructTintedDrawable(getResources(),

mBlockListExpanded ? R.drawable.ic_expand : R.drawable.ic_collapse);

+ blockedGroup.setExpanded(mBlockListExpanded);

blockedGroup.setIcon(icon);

}