Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/libpng/README.google

Issue 1032253003: Enable both static and dynamically linked libpng (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: addressing comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libpng/README.google
diff --git a/third_party/libpng/README.google b/third_party/libpng/README.google
index 4578d353cf264dbd6cbbb76dcc8e931209a17628..cacd08bce9594750daeeb1061ff51e06564c5912 100644
--- a/third_party/libpng/README.google
+++ b/third_party/libpng/README.google
@@ -3,14 +3,16 @@ Version: 1.6.16
License: libpng license
License File: LICENSE, pulled out of png.h
Description: png compression/decompression library
-Local Modifications: Created pnglibconf.h from pnglibconf.h.prebuilt (just a
- rename). Pulled LICENSE into its own file.
+Local Modifications: (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a
+ rename with a few additional settings enabled). (2) Created pngprefix.h
+ that is required when using the PNG_PREFIX define. (3) Pulled LICENSE into
+ its own file.
FAQ:
Q: Why does this directory exist?
A: libpng is pulled in through DEPS, but in order to build it using ninja, we
- need to create pnglibconf.h. In https://codereview.chromium.org/930283002/,
- we originally tried creating the file as an action, but this apparently led
- to a race condition on Windows, where some builds failed to create the file
- in time for other files to include it. By checking pnglibconf.h directly
- into Skia, we eliminate the race condition.
+ need to create pnglibconf.h and pngprefix.h. We originally tried creating
+ the file as an action in https://codereview.chromium.org/930283002/, but this
+ apparently led to a race condition on Windows, where some builds failed to
+ create the file in time for other files to include it. By checking these
+ files directly into Skia, we eliminate the race condition.
« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698