third_party/libpng/README.google - Issue 1032253003: Enable both static and dynamically linked libpng

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libpng/README.google

Issue 1032253003: Enable both static and dynamically linked libpng (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: addressing comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 URL: http://www.libpng.org/pub/png/libpng.html	1 URL: http://www.libpng.org/pub/png/libpng.html

2 Version: 1.6.16	2 Version: 1.6.16

3 License: libpng license	3 License: libpng license

4 License File: LICENSE, pulled out of png.h	4 License File: LICENSE, pulled out of png.h

5 Description: png compression/decompression library	5 Description: png compression/decompression library

6 Local Modifications: Created pnglibconf.h from pnglibconf.h.prebuilt (just a	6 Local Modifications: (1) Created pnglibconf.h from pnglibconf.h.prebuilt (a

7 rename). Pulled LICENSE into its own file.	7 rename with a few additional settings enabled). (2) Created pngprefix.h

	8 that is required when using the PNG_PREFIX define. (3) Pulled LICENSE into

	9 its own file.

8	10

9 FAQ:	11 FAQ:

10 Q: Why does this directory exist?	12 Q: Why does this directory exist?

11 A: libpng is pulled in through DEPS, but in order to build it using ninja, we	13 A: libpng is pulled in through DEPS, but in order to build it using ninja, we

12 need to create pnglibconf.h. In https://codereview.chromium.org/930283002/,	14 need to create pnglibconf.h and pngprefix.h. We originally tried creating

13 we originally tried creating the file as an action, but this apparently led	15 the file as an action in https://codereview.chromium.org/930283002/, but this

14 to a race condition on Windows, where some builds failed to create the file	16 apparently led to a race condition on Windows, where some builds failed to

15 in time for other files to include it. By checking pnglibconf.h directly	17 create the file in time for other files to include it. By checking these

16 into Skia, we eliminate the race condition.	18 files directly into Skia, we eliminate the race condition.

OLD	NEW

« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | third_party/libpng/pnglibconf.h » ('j') | no next file with comments »