Source/core/frame/FrameView.cpp - Issue 103213002: position:sticky should stick for the enclosing overflow ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 103213002: position:sticky should stick for the enclosing overflow ancestor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase patch + updated by review comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/sticky/sticky-top-overflow-expected.html ('K') | « LayoutTests/fast/css/sticky/sticky-top-overflow-expected.html ('k') | Source/core/rendering/RenderBoxModelObject.h » ('j') | Source/core/rendering/RenderLayer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index 0adb12f75ca370219354552de1723e37ad3088ae..f3134f3c37fbb173f58a98024172a7e962e28c48 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -1475,7 +1475,7 @@ bool FrameView::scrollContentsFastPath(const IntSize& scrollDelta, const IntRect

IntRect updateRect = pixelSnappedIntRect(layer->repainter().repaintRectIncludingNonCompositingDescendants());

- RenderLayer* enclosingCompositingLayer = layer->enclosingCompositingLayer(false);

+ RenderLayer* enclosingCompositingLayer = layer->enclosingCompositingLayer(ExcludeSelf);

if (enclosingCompositingLayer && !enclosingCompositingLayer->renderer()->isRenderView()) {

// If the fixed-position layer is contained by a composited layer that is not its containing block,

// then we have to invlidate that enclosing layer, not the RenderView.