Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 103213002: position:sticky should stick for the enclosing overflow ancestor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase patch + updated by review comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1457 matching lines...) Expand 10 before | Expand all | Expand 10 after
1468 } 1468 }
1469 1469
1470 if (layer->hasAncestorWithFilterOutsets()) { 1470 if (layer->hasAncestorWithFilterOutsets()) {
1471 // If the fixed layer has a blur/drop-shadow filter applied on at le ast one of its parents, we cannot 1471 // If the fixed layer has a blur/drop-shadow filter applied on at le ast one of its parents, we cannot
1472 // scroll using the fast path, otherwise the outsets of the filter w ill be moved around the page. 1472 // scroll using the fast path, otherwise the outsets of the filter w ill be moved around the page.
1473 return false; 1473 return false;
1474 } 1474 }
1475 1475
1476 IntRect updateRect = pixelSnappedIntRect(layer->repainter().repaintRectI ncludingNonCompositingDescendants()); 1476 IntRect updateRect = pixelSnappedIntRect(layer->repainter().repaintRectI ncludingNonCompositingDescendants());
1477 1477
1478 RenderLayer* enclosingCompositingLayer = layer->enclosingCompositingLaye r(false); 1478 RenderLayer* enclosingCompositingLayer = layer->enclosingCompositingLaye r(ExcludeSelf);
1479 if (enclosingCompositingLayer && !enclosingCompositingLayer->renderer()- >isRenderView()) { 1479 if (enclosingCompositingLayer && !enclosingCompositingLayer->renderer()- >isRenderView()) {
1480 // If the fixed-position layer is contained by a composited layer th at is not its containing block, 1480 // If the fixed-position layer is contained by a composited layer th at is not its containing block,
1481 // then we have to invlidate that enclosing layer, not the RenderVie w. 1481 // then we have to invlidate that enclosing layer, not the RenderVie w.
1482 updateRect.moveBy(scrollPosition()); 1482 updateRect.moveBy(scrollPosition());
1483 IntRect previousRect = updateRect; 1483 IntRect previousRect = updateRect;
1484 previousRect.move(scrollDelta); 1484 previousRect.move(scrollDelta);
1485 updateRect.unite(previousRect); 1485 updateRect.unite(previousRect);
1486 enclosingCompositingLayer->repainter().setBackingNeedsRepaintInRect( updateRect); 1486 enclosingCompositingLayer->repainter().setBackingNeedsRepaintInRect( updateRect);
1487 } else { 1487 } else {
1488 // Coalesce the repaints that will be issued to the renderView. 1488 // Coalesce the repaints that will be issued to the renderView.
(...skipping 2016 matching lines...) Expand 10 before | Expand all | Expand 10 after
3505 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3505 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3506 { 3506 {
3507 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3507 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3508 if (AXObjectCache* cache = axObjectCache()) { 3508 if (AXObjectCache* cache = axObjectCache()) {
3509 cache->remove(scrollbar); 3509 cache->remove(scrollbar);
3510 cache->handleScrollbarUpdate(this); 3510 cache->handleScrollbarUpdate(this);
3511 } 3511 }
3512 } 3512 }
3513 3513
3514 } // namespace WebCore 3514 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698