Source/core/rendering/RenderLayer.h - Issue 103213002: position:sticky should stick for the enclosing overflow ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.h

Issue 103213002: position:sticky should stick for the enclosing overflow ancestor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/sticky/sticky-top-overflow.html ('K') | « Source/core/rendering/RenderBoxModelObject.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | Source/core/rendering/RenderLayerCompositor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayer.h

diff --git a/Source/core/rendering/RenderLayer.h b/Source/core/rendering/RenderLayer.h

index afcfb9c5d162e1218508025e3ead04511bba658e..b82e9f64b6a81aca099fd922425267aed0d4d912 100644

--- a/Source/core/rendering/RenderLayer.h

+++ b/Source/core/rendering/RenderLayer.h

@@ -226,6 +226,8 @@ public:

// The layer relative to which clipping rects for this layer are computed.

RenderLayer* clippingRootForPainting() const;

+ RenderLayer* enclosingOverflowClipLayer(bool includeSelf = true) const;

Julien - ping for review 2014/01/06 17:22:07 Why didn't we merge the IncludeSelfOrNot enum too?

ostap 2014/01/08 01:46:40 Done.

// Enclosing compositing layer; if includeSelf is true, may return this.

RenderLayer* enclosingCompositingLayer(bool includeSelf = true) const;

RenderLayer* enclosingCompositingLayerForRepaint(bool includeSelf = true) const;