Source/core/rendering/RenderLayer.h - Issue 103213002: position:sticky should stick for the enclosing overflow ancestor

Side by Side Diff: Source/core/rendering/RenderLayer.h

Issue 103213002: position:sticky should stick for the enclosing overflow ancestor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css/sticky/sticky-top-overflow.html ('K') | « Source/core/rendering/RenderBoxModelObject.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | Source/core/rendering/RenderLayerCompositor.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.

3 * Copyright (C) 2013 Intel Corporation. All rights reserved.	3 * Copyright (C) 2013 Intel Corporation. All rights reserved.

4 *	4 *

5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.	5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.

6 *	6 *

7 * Other contributors:	7 * Other contributors:

8 * Robert O'Callahan <roc+@cs.cmu.edu>	8 * Robert O'Callahan <roc+@cs.cmu.edu>

9 * David Baron <dbaron@fas.harvard.edu>	9 * David Baron <dbaron@fas.harvard.edu>

10 * Christian Biesinger <cbiesinger@web.de>	10 * Christian Biesinger <cbiesinger@web.de>

(...skipping 208 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
219 // Gets the nearest enclosing positioned ancestor layer (also includes	219 // Gets the nearest enclosing positioned ancestor layer (also includes

220 // the <html> layer and the root layer).	220 // the <html> layer and the root layer).

221 RenderLayer* enclosingPositionedAncestor() const;	221 RenderLayer* enclosingPositionedAncestor() const;

222	222

223 // Returns the nearest enclosing layer that is scrollable.	223 // Returns the nearest enclosing layer that is scrollable.

224 RenderLayer* enclosingScrollableLayer() const;	224 RenderLayer* enclosingScrollableLayer() const;

225	225

226 // The layer relative to which clipping rects for this layer are computed.	226 // The layer relative to which clipping rects for this layer are computed.

227 RenderLayer* clippingRootForPainting() const;	227 RenderLayer* clippingRootForPainting() const;

228	228

	229 RenderLayer* enclosingOverflowClipLayer(bool includeSelf = true) const;
	Julien - ping for review 2014/01/06 17:22:07 Why didn't we merge the IncludeSelfOrNot enum too? Why didn't we merge the IncludeSelfOrNot enum too? This makes the code more readable. ostap 2014/01/08 01:46:40 Done. Show quoted text On 2014/01/06 17:22:07, Julien Chaffraix - CET wrote: > Why didn't we merge the IncludeSelfOrNot enum too? This makes the code more > readable. Done.
	230

229 // Enclosing compositing layer; if includeSelf is true, may return this.	231 // Enclosing compositing layer; if includeSelf is true, may return this.

230 RenderLayer* enclosingCompositingLayer(bool includeSelf = true) const;	232 RenderLayer* enclosingCompositingLayer(bool includeSelf = true) const;

231 RenderLayer* enclosingCompositingLayerForRepaint(bool includeSelf = true) co nst;	233 RenderLayer* enclosingCompositingLayerForRepaint(bool includeSelf = true) co nst;

232 // Ancestor compositing layer, excluding this.	234 // Ancestor compositing layer, excluding this.

233 RenderLayer* ancestorCompositingLayer() const { return enclosingCompositingL ayer(false); }	235 RenderLayer* ancestorCompositingLayer() const { return enclosingCompositingL ayer(false); }

234	236

235 // Ancestor composited scrolling layer at or above our containing block.	237 // Ancestor composited scrolling layer at or above our containing block.

236 RenderLayer* ancestorCompositedScrollingLayer() const;	238 RenderLayer* ancestorCompositedScrollingLayer() const;

237	239

238 // Ancestor scrolling layer at or above our containing block.	240 // Ancestor scrolling layer at or above our containing block.

(...skipping 495 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
734	736

735 } // namespace WebCore	737 } // namespace WebCore

736	738

737 #ifndef NDEBUG	739 #ifndef NDEBUG

738 // Outside the WebCore namespace for ease of invocation from gdb.	740 // Outside the WebCore namespace for ease of invocation from gdb.

739 void showLayerTree(const WebCore::RenderLayer*);	741 void showLayerTree(const WebCore::RenderLayer*);

740 void showLayerTree(const WebCore::RenderObject*);	742 void showLayerTree(const WebCore::RenderObject*);

741 #endif	743 #endif

742	744

743 #endif // RenderLayer_h	745 #endif // RenderLayer_h

OLD	NEW