Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5620)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 1032073003: [Icons NTP] Use GetVariationParamValue instead of experiment prefix to determine when large icons a… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed in files Sam recommended. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 21bf0b6746f379fb1e3831faa53ebbec5e74bdb1..7cb5d7d49786efc17484c3733ecfadd5f07e13f1 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -6,7 +6,6 @@
#include "base/i18n/rtl.h"
#include "base/json/string_escape.h"
-#include "base/metrics/field_trial.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -17,6 +16,7 @@
#include "chrome/grit/renderer_resources.h"
#include "chrome/renderer/searchbox/searchbox.h"
#include "components/crx_file/id_util.h"
+#include "components/variations/variations_associated_data.h"
#include "content/public/renderer/render_view.h"
#include "third_party/WebKit/public/platform/WebURLRequest.h"
#include "third_party/WebKit/public/web/WebDocument.h"
@@ -64,8 +64,7 @@ base::string16 V8ValueToUTF16(v8::Handle<v8::Value> v) {
// Returns whether we should use large icons on NTP.
bool IsIconNTPEnabled() {
- return StartsWithASCII(base::FieldTrialList::FindFullName("IconNTP"),
- "Enabled", true);
+ return variations::GetVariationParamValue("IconNTP", "state") == "enabled";
}
// Converts string16 to V8 String.
« chrome/browser/favicon/favicon_tab_helper.cc ('K') | « chrome/browser/search/local_ntp_source.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698