chrome/browser/search/local_ntp_source.cc - Issue 1032073003: [Icons NTP] Use GetVariationParamValue instead of experiment prefix to determine when large icons a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/local_ntp_source.cc

Issue 1032073003: [Icons NTP] Use GetVariationParamValue instead of experiment prefix to determine when large icons a… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed in files Sam recommended. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/favicon/favicon_tab_helper.cc ('K') | « chrome/browser/favicon/favicon_tab_helper.cc ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/local_ntp_source.cc

diff --git a/chrome/browser/search/local_ntp_source.cc b/chrome/browser/search/local_ntp_source.cc

index ba661d515433d77aa2317fe286cb64296f28c110..9e2fdef8a3f276861f62f04996d5f376252f0860 100644

--- a/chrome/browser/search/local_ntp_source.cc

+++ b/chrome/browser/search/local_ntp_source.cc

@@ -20,6 +20,7 @@

#include "chrome/grit/generated_resources.h"

#include "components/search_engines/template_url_prepopulate_data.h"

#include "components/search_engines/template_url_service.h"

+#include "components/variations/variations_associated_data.h"

#include "grit/browser_resources.h"

#include "grit/theme_resources.h"

#include "net/url_request/url_request.h"

@@ -81,8 +82,7 @@ bool DefaultSearchProviderIsGoogle(Profile* profile) {

// Returns whether icon NTP is enabled.

bool IsIconNTPEnabled() {

- return StartsWithASCII(base::FieldTrialList::FindFullName("IconNTP"),

- "Enabled", true);

+ return variations::GetVariationParamValue("IconNTP", "state") == "enabled";

}

// Returns whether we are in the Fast NTP experiment or not.