Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1031923003: Autofill: Recognize phone numbers in input fields of type number. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@autofill_b464002_a
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Recognize phone numbers in input fields of type number. Improve PhoneFieldTest to test this. Committed: https://crrev.com/70deb4f47981e6b05ab950d1a8bce6fa460a471b Cr-Commit-Position: refs/heads/master@{#322446}

Patch Set 1 : #

Patch Set 2 : fix bad test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/data/autofill/heuristics/output/bug_469012.out View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
5 years, 9 months ago (2015-03-26 04:25:48 UTC) #3
Evan Stade
lgtm
5 years, 9 months ago (2015-03-26 15:35:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031923003/40001
5 years, 9 months ago (2015-03-26 18:21:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-26 19:27:43 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 19:28:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70deb4f47981e6b05ab950d1a8bce6fa460a471b
Cr-Commit-Position: refs/heads/master@{#322446}

Powered by Google App Engine
This is Rietveld 408576698