components/autofill/core/browser/phone_field.cc - Issue 1031923003: Autofill: Recognize phone numbers in input fields of type number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/phone_field.cc

Issue 1031923003: Autofill: Recognize phone numbers in input fields of type number. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autofill_b464002_a

Patch Set: fix bad test expectation Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/autofill/heuristics/output/bug_469012.out ('k') | components/autofill/core/browser/phone_field_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/phone_field.cc

diff --git a/components/autofill/core/browser/phone_field.cc b/components/autofill/core/browser/phone_field.cc

index 3c6b351e7d2317c514196b59ec73b4dbf4622a1b..77a8d9f08aa6bf22eec63f325d6101b9478298eb 100644

--- a/components/autofill/core/browser/phone_field.cc

+++ b/components/autofill/core/browser/phone_field.cc

@@ -278,7 +278,7 @@ bool PhoneField::ParsePhoneField(AutofillScanner* scanner,

AutofillField** field) {

return ParseFieldSpecifics(scanner,

base::UTF8ToUTF16(regex),

- MATCH_DEFAULT | MATCH_TELEPHONE,

+ MATCH_DEFAULT | MATCH_TELEPHONE | MATCH_NUMBER,

field);

}