Keeps the histograms in sync with the IME extension code.

Keeps the histograms in sync with the IME extension code.

BUG=367631
TEST=None

Committed: https://crrev.com/82497cf91e8f90e52d0250985f6bb99fbec65f95
Cr-Commit-Position: refs/heads/master@{#321940}

[Shu Chen, 2015-03-23 08:50:12]

shuchen@chromium.org changed reviewers:
+ isherman@chromium.org

[Shu Chen, 2015-03-23 08:50:13]

hi isherman@, can you please help review this cl? Thanks

[Ilya Sherman, 2015-03-23 21:00:56]

https://codereview.chromium.org/1031573002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1031573002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:51623: +  </int>
Please either add new items at the end of the enum, or rename the histogram. 
The histograms dashboard is not smart enough to know how to associate different
labels for different backing enum constants depending on the app version number,
so you'll need to keep the labels consistent in order for old data to be
viewable.  If you don't care about old data being viewable, then please rename
the histogram and mark the old one as <obsolete>, so anyone else who encounters
the histogram isn't tripped up by the change in labels.

[Shu Chen, 2015-03-24 03:24:45]

https://codereview.chromium.org/1031573002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1031573002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:51623: +  </int>
On 2015/03/23 21:00:56, Ilya Sherman wrote:
> Please either add new items at the end of the enum, or rename the histogram. 
> The histograms dashboard is not smart enough to know how to associate
different
> labels for different backing enum constants depending on the app version
number,
> so you'll need to keep the labels consistent in order for old data to be
> viewable.  If you don't care about old data being viewable, then please rename
> the histogram and mark the old one as <obsolete>, so anyone else who
encounters
> the histogram isn't tripped up by the change in labels.

Done. I've made a new histogram InputMethod.Commit.Type2 referring to
IMECommitType2.
As for InputMethod.PkCommit.Type, it is a un-launched feature, so we don't care
about the history data, so I didn't make a new one but just link it to
IMECommitType2.

Is that OK?

[Ilya Sherman, 2015-03-24 03:51:06]

LGTM, thanks.

https://codereview.chromium.org/1031573002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1031573002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:51623: +  </int>
On 2015/03/24 03:24:45, Shu Chen wrote:
> On 2015/03/23 21:00:56, Ilya Sherman wrote:
> > Please either add new items at the end of the enum, or rename the histogram.

> > The histograms dashboard is not smart enough to know how to associate
> different
> > labels for different backing enum constants depending on the app version
> number,
> > so you'll need to keep the labels consistent in order for old data to be
> > viewable.  If you don't care about old data being viewable, then please
rename
> > the histogram and mark the old one as <obsolete>, so anyone else who
> encounters
> > the histogram isn't tripped up by the change in labels.
> 
> Done. I've made a new histogram InputMethod.Commit.Type2 referring to
> IMECommitType2.
> As for InputMethod.PkCommit.Type, it is a un-launched feature, so we don't
care
> about the history data, so I didn't make a new one but just link it to
> IMECommitType2.
> 
> Is that OK?

Yep, if the histogram is for an unlaunched feature, there shouldn't be much data
for it, and so it should be fine to just change the backing histogram.

By the way, please also take a moment to update the backing JS code to warn
future editors of the code to only append items to the enum, so that this
doesn't come up again as an issue in the future :)

https://codereview.chromium.org/1031573002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1031573002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11751: +    obsolete.
nit: Please use an <obsolete> tag, and mention the updated histogram name within
it.  (See other obsolete histograms in this file for examples.)

[Shu Chen, 2015-03-24 03:58:15]

Thanks for your review!

https://codereview.chromium.org/1031573002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1031573002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11751: +    obsolete.
On 2015/03/24 03:51:06, Ilya Sherman wrote:
> nit: Please use an <obsolete> tag, and mention the updated histogram name
within
> it.  (See other obsolete histograms in this file for examples.)

Done.

[Shu Chen, 2015-03-24 04:03:54]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-03-24 04:03:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1031573002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-24 04:04:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1031573002/60001

[commit-bot: I haz the power, 2015-03-24 05:58:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-24 06:00:20]

Patchset 4 (id:??) landed as
https://crrev.com/82497cf91e8f90e52d0250985f6bb99fbec65f95
Cr-Commit-Position: refs/heads/master@{#321940}