Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1031573002: Keeps the histograms in sync with the IME extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4d36619ab5c661fca1ebe7526473152b376d5933..c63d4aab3cee28e48cdd585dcf0c62fd98321e96 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -51610,15 +51610,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
Types X, commits Y as the top suggestion.
</int>
<int value="2" label="X -&gt; X(1)">
- Types X, commits X as the non-top suggestion.
+ Types X, commits X as the 2nd suggestion.
</int>
<int value="3" label="X -&gt; Y(1)">
- Types X, commits Y as the non-top suggestion.
+ Types X, commits Y as the 2nd suggestion.
</int>
- <int value="4" label="Prediction">Commits a prediction suggestion.</int>
- <int value="5" label="Revert">
+ <int value="4" label="X -&gt; X(2)">
+ Types X, commits X as the 3rd/other suggestion.
+ </int>
+ <int value="5" label="X -&gt; Y(2)">
+ Types X, commits Y as the 3rd/other suggestion.
+ </int>
Ilya Sherman 2015/03/23 21:00:56 Please either add new items at the end of the enum
Shu Chen 2015/03/24 03:24:45 Done. I've made a new histogram InputMethod.Commit
Ilya Sherman 2015/03/24 03:51:06 Yep, if the histogram is for an unlaunched feature
+ <int value="6" label="Prediction">Commits a prediction suggestion.</int>
+ <int value="7" label="Revert">
Reverts the previous auto-corrected and committed word.
</int>
+ <int value="8" label="Voice">The commit is triggered by voice input.</int>
</enum>
<enum name="IMECorrectionLevel" type="int">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698