Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: ui/base/ime/composition_text.cc

Issue 1031533002: Supports the invisible underline for native input fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revised per comments and fixed test failures. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/render_text.h » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/composition_text.cc
diff --git a/ui/base/ime/composition_text.cc b/ui/base/ime/composition_text.cc
index f85bc7487587d7aa85d3c104faec92e302e82064..325294174c9c5ac0de029dde9d2510dafcde20c1 100644
--- a/ui/base/ime/composition_text.cc
+++ b/ui/base/ime/composition_text.cc
@@ -7,6 +7,8 @@
namespace ui {
CompositionText::CompositionText() {
+ underlines.push_back(CompositionUnderline());
msw 2015/03/26 20:22:48 Why do we need this change? It seems odd to add th
Shu Chen 2015/03/30 03:56:21 It was to make the tests can pass. I've just check
+ underlines[0].color = SK_ColorBLACK;
}
CompositionText::~CompositionText() {
« no previous file with comments | « no previous file | ui/gfx/render_text.h » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698