Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: ui/base/ime/composition_text.cc

Issue 1031533002: Supports the invisible underline for native input fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revised per comments and fixed test failures. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/gfx/render_text.h » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/ime/composition_text.h" 5 #include "ui/base/ime/composition_text.h"
6 6
7 namespace ui { 7 namespace ui {
8 8
9 CompositionText::CompositionText() { 9 CompositionText::CompositionText() {
10 underlines.push_back(CompositionUnderline());
msw 2015/03/26 20:22:48 Why do we need this change? It seems odd to add th
Shu Chen 2015/03/30 03:56:21 It was to make the tests can pass. I've just check
11 underlines[0].color = SK_ColorBLACK;
10 } 12 }
11 13
12 CompositionText::~CompositionText() { 14 CompositionText::~CompositionText() {
13 } 15 }
14 16
15 void CompositionText::Clear() { 17 void CompositionText::Clear() {
16 text.clear(); 18 text.clear();
17 underlines.clear(); 19 underlines.clear();
18 selection = gfx::Range(); 20 selection = gfx::Range();
19 } 21 }
20 22
21 } // namespace ui 23 } // namespace ui
OLDNEW
« no previous file with comments | « no previous file | ui/gfx/render_text.h » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698