Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1031493002: Add "StaleWhileRevalidateCacheControl" runtime flag. (Closed)

Created:
5 years, 9 months ago by yhirano
Modified:
5 years, 8 months ago
Reviewers:
tkent, Adam Rice
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add "StaleWhileRevalidateCacheControl" runtime flag. stale-while-revalidate is an HTTP cache-control header[1][2] and we would like to add a runtime enabled flag to control the Blink cache. The flag is disabled by default. It will be enabled when the corresponding flag is enabled in chrome://flags. 1: http://tools.ietf.org/html/rfc5861 2: https://docs.google.com/a/chromium.org/document/d/1nBhr25nSJgoyAh4S1-U5h2sH70Iz4RR0NAfXNL79G5Y/edit#heading=h.wu5anpnlvlfy BUG=469560 R=ricea@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192812

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
yhirano
https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode145 Source/platform/RuntimeEnabledFeatures.in:145: StaleWhileRevalidate It's OK to add status=test if you want ...
5 years, 9 months ago (2015-03-23 04:09:43 UTC) #2
Adam Rice
https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode145 Source/platform/RuntimeEnabledFeatures.in:145: StaleWhileRevalidate On 2015/03/23 04:09:43, yhirano wrote: > It's OK ...
5 years, 9 months ago (2015-03-26 12:28:55 UTC) #3
yhirano
https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode145 Source/platform/RuntimeEnabledFeatures.in:145: StaleWhileRevalidate On 2015/03/26 12:28:55, Adam Rice wrote: > On ...
5 years, 9 months ago (2015-03-27 07:09:00 UTC) #4
Adam Rice
On 2015/03/27 07:09:00, yhirano wrote: > https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in > File Source/platform/RuntimeEnabledFeatures.in (right): > > https://codereview.chromium.org/1031493002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode145 > ...
5 years, 9 months ago (2015-03-27 12:39:27 UTC) #5
yhirano
+tkent for OWNER review.
5 years, 8 months ago (2015-03-30 11:11:35 UTC) #7
tkent
I can't image what's this flag is for. What's stale? What's revalidated? Is it related ...
5 years, 8 months ago (2015-03-30 23:09:19 UTC) #8
yhirano
On 2015/03/30 23:09:19, tkent wrote: > I can't image what's this flag is for. What's ...
5 years, 8 months ago (2015-03-31 00:51:52 UTC) #9
yhirano
On 2015/03/31 00:51:52, yhirano wrote: > On 2015/03/30 23:09:19, tkent wrote: > > I can't ...
5 years, 8 months ago (2015-03-31 00:52:06 UTC) #10
tkent
On 2015/03/31 00:52:06, yhirano wrote: > On 2015/03/31 00:51:52, yhirano wrote: > > On 2015/03/30 ...
5 years, 8 months ago (2015-03-31 00:56:04 UTC) #11
yhirano
On 2015/03/31 00:56:04, tkent wrote: > On 2015/03/31 00:52:06, yhirano wrote: > > On 2015/03/31 ...
5 years, 8 months ago (2015-03-31 01:11:55 UTC) #12
tkent
> How about StaleWhileRevalidateCacheControl? I don't like adding "HTTP" prefix > because the first character ...
5 years, 8 months ago (2015-03-31 01:15:28 UTC) #13
yhirano
On 2015/03/31 01:15:28, tkent wrote: > > How about StaleWhileRevalidateCacheControl? I don't like adding "HTTP" ...
5 years, 8 months ago (2015-03-31 06:50:04 UTC) #14
tkent
lgtm
5 years, 8 months ago (2015-03-31 06:54:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031493002/20001
5 years, 8 months ago (2015-03-31 06:55:19 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 08:42:50 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192812

Powered by Google App Engine
This is Rietveld 408576698