Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031473002: Sync HTML element interfaces S-V with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, feature-media-reviews_chromium.org, nessy, arv+blink, blink-reviews-style_chromium.org, vivekg_samsung, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, vivekg, dglazkov+blink, Inactive, vcarbune.chromium, philipj_slow
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync HTML element interfaces S-V with the spec Switch to linking to #the-foo-element instead of #htmlfooelement, as it gives good extra clues in cases like HTMLTableCaptionElement and HTMLTableCellElement. It also doesn't skip past constructors, etc. At the same time also move Event.path out of the non-standard section, as it's in the Shadow DOM spec (below HTMLShadowElement). Also give HTMLInputElement.autocapitalize its own section. There are no changes to the generated code other than order. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192327

Patch Set 1 #

Total comments: 2

Patch Set 2 : link to col element too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -69 lines) Patch
M Source/core/events/Event.idl View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/html/HTMLScriptElement.idl View 1 chunk +17 lines, -5 lines 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +12 lines, -8 lines 0 comments Download
M Source/core/html/HTMLShadowElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSpanElement.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/HTMLStyleElement.idl View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableCaptionElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.idl View 1 chunk +23 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTableColElement.idl View 1 1 chunk +8 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.idl View 1 chunk +25 lines, -20 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.idl View 1 chunk +10 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.idl View 1 chunk +11 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTemplateElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 3 chunks +18 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTitleElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLUListElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLUnknownElement.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/HTMLVideoElement.idl View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-22 16:01:48 UTC) #2
Jens Widell
LGTM https://codereview.chromium.org/1031473002/diff/1/Source/core/html/HTMLTableColElement.idl File Source/core/html/HTMLTableColElement.idl (right): https://codereview.chromium.org/1031473002/diff/1/Source/core/html/HTMLTableColElement.idl#newcode21 Source/core/html/HTMLTableColElement.idl:21: // https://html.spec.whatwg.org/#the-colgroup-element Maybe link to #the-col-element as well, ...
5 years, 9 months ago (2015-03-22 16:19:21 UTC) #3
philipj_slow
link to col element too
5 years, 9 months ago (2015-03-22 17:32:15 UTC) #4
philipj_slow
https://codereview.chromium.org/1031473002/diff/1/Source/core/html/HTMLTableColElement.idl File Source/core/html/HTMLTableColElement.idl (right): https://codereview.chromium.org/1031473002/diff/1/Source/core/html/HTMLTableColElement.idl#newcode21 Source/core/html/HTMLTableColElement.idl:21: // https://html.spec.whatwg.org/#the-colgroup-element On 2015/03/22 16:19:21, Jens Widell wrote: > ...
5 years, 9 months ago (2015-03-22 17:32:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031473002/20001
5 years, 9 months ago (2015-03-22 17:32:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53678)
5 years, 9 months ago (2015-03-22 19:11:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031473002/20001
5 years, 9 months ago (2015-03-22 23:40:39 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 02:07:51 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192327

Powered by Google App Engine
This is Rietveld 408576698