Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 1031473002: Sync HTML element interfaces S-V with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: link to col element too Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLScriptElement.idl ('k') | Source/core/html/HTMLShadowElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.idl
diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl
index 0c4f6281a30329aaf4cab4f968d69d2e9f54077a..6d8be3492ae57e8516cac10aed9416f1ae86018c 100644
--- a/Source/core/html/HTMLSelectElement.idl
+++ b/Source/core/html/HTMLSelectElement.idl
@@ -19,39 +19,43 @@
* Boston, MA 02110-1301, USA.
*/
-// http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#htmlselectelement
+// https://html.spec.whatwg.org/#the-select-element
interface HTMLSelectElement : HTMLElement {
+ // TODO(philipj): attribute DOMString autocomplete;
[Reflect] attribute boolean autofocus;
[Reflect] attribute boolean disabled;
- [ImplementedAs=formOwner] readonly attribute HTMLFormElement form;
+ [ImplementedAs=formOwner] readonly attribute HTMLFormElement? form;
attribute boolean multiple;
[Reflect] attribute DOMString name;
[Reflect] attribute boolean required;
+ // TODO(philipj): size should be unsigned long.
attribute long size;
readonly attribute DOMString type;
readonly attribute HTMLOptionsCollection options;
+ // TODO(philipj): The length setter should never throw.
[RaisesException=Setter] attribute unsigned long length;
-
- getter Element item(unsigned long index);
- Element namedItem([Default=Undefined] optional DOMString name);
+ getter Element? item(unsigned long index);
+ // TODO(philipj): The name argument should not be optional.
+ HTMLOptionElement? namedItem([Default=Undefined] optional DOMString name);
[RaisesException, TypeChecking=Interface] void add((HTMLOptionElement or HTMLOptGroupElement) element,
optional (HTMLElement or long)? before = null);
[RaisesException] void remove(); // ChildNode overload
void remove(long index);
- [RaisesException, TypeChecking=Interface] setter HTMLOptionElement (unsigned long index, HTMLOptionElement? value);
+ [RaisesException, TypeChecking=Interface] setter void (unsigned long index, HTMLOptionElement? option);
readonly attribute HTMLCollection selectedOptions;
- attribute long selectedIndex;
- attribute DOMString value;
+ attribute long selectedIndex;
+ attribute DOMString value;
readonly attribute boolean willValidate;
readonly attribute ValidityState validity;
readonly attribute DOMString validationMessage;
boolean checkValidity();
boolean reportValidity();
+ // TODO(philipj): The error argument should not be nullable.
void setCustomValidity([TreatUndefinedAs=NullString] DOMString? error);
readonly attribute NodeList labels;
« no previous file with comments | « Source/core/html/HTMLScriptElement.idl ('k') | Source/core/html/HTMLShadowElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698