Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 103133002: Exclude chrome_browser_main.cc's printf in PRESUBMIT.py. (Closed)

Created:
7 years ago by Alexei Svitkine (slow)
Modified:
7 years ago
Reviewers:
Nico, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude chrome_browser_main.cc's printf in PRESUBMIT.py. The printf in that file is legitimate, so it shouldn't trigger the warning. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
7 years ago (2013-12-03 22:33:22 UTC) #1
Nico
lgtm
7 years ago (2013-12-03 22:34:13 UTC) #2
Alexei Svitkine (slow)
+maruel for OWNERS (since Nico isn't :\)
7 years ago (2013-12-03 22:39:44 UTC) #3
M-A Ruel
rubberstamp lgtm. You may want NOTRY=true since it is not a code change.
7 years ago (2013-12-04 00:58:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/103133002/1
7 years ago (2013-12-04 01:38:06 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-04 01:41:53 UTC) #6
Message was sent while issue was closed.
Change committed as 238522

Powered by Google App Engine
This is Rietveld 408576698