OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 848 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
859 | 859 |
860 return [] | 860 return [] |
861 | 861 |
862 | 862 |
863 def _CheckSpamLogging(input_api, output_api): | 863 def _CheckSpamLogging(input_api, output_api): |
864 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS | 864 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS |
865 black_list = (_EXCLUDED_PATHS + | 865 black_list = (_EXCLUDED_PATHS + |
866 _TEST_CODE_EXCLUDED_PATHS + | 866 _TEST_CODE_EXCLUDED_PATHS + |
867 input_api.DEFAULT_BLACK_LIST + | 867 input_api.DEFAULT_BLACK_LIST + |
868 (r"^base[\\\/]logging\.h$", | 868 (r"^base[\\\/]logging\.h$", |
| 869 r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", |
869 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" | 870 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" |
870 r"logging_native_handler\.cc", | 871 r"logging_native_handler\.cc$", |
871 r"^remoting[\\\/]base[\\\/]logging\.h$", | 872 r"^remoting[\\\/]base[\\\/]logging\.h$", |
872 r"^sandbox[\\\/]linux[\\\/].*",)) | 873 r"^sandbox[\\\/]linux[\\\/].*",)) |
873 source_file_filter = lambda x: input_api.FilterSourceFile( | 874 source_file_filter = lambda x: input_api.FilterSourceFile( |
874 x, white_list=(file_inclusion_pattern,), black_list=black_list) | 875 x, white_list=(file_inclusion_pattern,), black_list=black_list) |
875 | 876 |
876 log_info = [] | 877 log_info = [] |
877 printf = [] | 878 printf = [] |
878 | 879 |
879 for f in input_api.AffectedSourceFiles(source_file_filter): | 880 for f in input_api.AffectedSourceFiles(source_file_filter): |
880 contents = input_api.ReadFile(f, 'rb') | 881 contents = input_api.ReadFile(f, 'rb') |
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1169 trybots += ['cros_x86'] | 1170 trybots += ['cros_x86'] |
1170 | 1171 |
1171 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1172 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
1172 # unless they're .gyp(i) files as changes to those files can break the gyp | 1173 # unless they're .gyp(i) files as changes to those files can break the gyp |
1173 # step on that bot. | 1174 # step on that bot. |
1174 if (not all(re.search('^chrome', f) for f in files) or | 1175 if (not all(re.search('^chrome', f) for f in files) or |
1175 any(re.search('\.gypi?$', f) for f in files)): | 1176 any(re.search('\.gypi?$', f) for f in files)): |
1176 trybots += ['android_aosp'] | 1177 trybots += ['android_aosp'] |
1177 | 1178 |
1178 return trybots | 1179 return trybots |
OLD | NEW |